这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(client): handle empty response bodies for various content types #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 26, 2025
Merged

fix(client): handle empty response bodies for various content types #2519

merged 4 commits into from
Aug 26, 2025

Conversation

@volesen
Copy link
Contributor

@volesen volesen commented Aug 25, 2025 •
edited
Loading

Fixes #2517

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Aug 25, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 95f00fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 25, 2025

@volesen is attempting to deploy a commit to the Hey API Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. client Client package related labels Aug 25, 2025
@volesen volesen marked this pull request as draft August 25, 2025 08:00
@volesen volesen force-pushed the volesen/handle-empty-responses branch from cddf27f to a720d20 Compare August 25, 2025 08:01
@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 25, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2519

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2519

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2519

commit: 95f00fa

@codecov
Copy link

codecov bot commented Aug 25, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 48.93617% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.06%. Comparing base (5dcb0c2) to head (95f00fa).
⚠️ Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
.../src/plugins/@hey-api/client-next/bundle/client.ts 0.00% 23 Missing ⚠️
...src/plugins/@hey-api/client-fetch/bundle/client.ts 95.83% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2519      +/-   ##
==========================================
+ Coverage   23.99%   24.06%   +0.07%     
==========================================
  Files         351      357       +6     
  Lines       34971    35452     +481     
  Branches     1499     1539      +40     
==========================================
+ Hits         8390     8531     +141     
- Misses      26569    26908     +339     
- Partials       12       13       +1
Flag Coverage Δ
unittests 24.06% <48.93%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@volesen volesen marked this pull request as ready for review August 25, 2025 08:30
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. bug 🔥 Something isn't working and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Aug 25, 2025
mrlubos
mrlubos requested changes Aug 25, 2025
View reviewed changes
Copy link
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the same changes to client-next so they stay in sync?

@volesen volesen force-pushed the volesen/handle-empty-responses branch from 68e4247 to 8f3d7c8 Compare August 25, 2025 19:15
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Aug 25, 2025
@volesen volesen force-pushed the volesen/handle-empty-responses branch from 8f3d7c8 to 70f63e9 Compare August 26, 2025 06:22
mrlubos
mrlubos approved these changes Aug 26, 2025
View reviewed changes
Copy link
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 26, 2025
@mrlubos mrlubos merged commit 995f107 into hey-api:main Aug 26, 2025
12 of 13 checks passed
This was referenced Aug 26, 2025
Merged
Open
Open
Open
@hey-api hey-api bot mentioned this pull request Oct 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrlubos mrlubos mrlubos approved these changes

Assignees

No one assigned

Labels

bug 🔥 Something isn't working client Client package related lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

client-fetch returns {} on empty bodies regardless of content-type or requested parseAs

2 participants

@volesen @mrlubos