这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(operation): ensure output case handling is robust by checking for object type #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2025
Merged

fix(operation): ensure output case handling is robust by checking for object type #2356

merged 1 commit into from
Jul 25, 2025
+3 −2

Conversation

seriouslag
Copy link
Contributor

@seriouslag seriouslag commented Jul 24, 2025 •
edited
Loading

This PR validates that the output in the config is an object before trying to use the 'in' operator on the value.

output can be either a string or an object; this check helps handle the case where' output' is a string.

Created to support #1947

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2025

⚠️ No Changeset found

Latest commit: d49741b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jul 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2025 7:38pm

@codecov Codecov
Copy link

codecov bot commented Jul 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 22.52%. Comparing base (9ccd969) to head (d49741b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...s/openapi-ts/src/openApi/shared/utils/operation.ts 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2356      +/-   ##
==========================================
- Coverage   22.52%   22.52%   -0.01%     
==========================================
  Files         324      324              
  Lines       31857    31858       +1     
  Branches     1232     1232              
==========================================
  Hits         7177     7177              
- Misses      24671    24672       +1     
  Partials        9        9
Flag Coverage Δ
unittests 22.52% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 24, 2025

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2356

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2356

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2356

commit: d49741b

@mrlubos mrlubos merged commit f604323 into hey-api:main Jul 25, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrlubos mrlubos mrlubos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seriouslag @mrlubos