Run & review this pull request in StackBlitz Codeflow.

🦋 Changeset detected

Latest commit: 4a77615

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Hey @mrlubos, looks like I'm missing some changes for the tests as well, but I'm not 100% sure where and how I should update the snapshots.. I'm not that familiar with snapshot testing in the first place..
Could you point me to what I would need to adjust and how I can trigger the same tests locally? Running the test script doesnt seem to run the snapshot tests..

@btmnk hey, run pnpm openapi-ts-tests test:update to update snapshots. Can you also add this change to the Next.js client and possibly Axios/Nuxt if they have the same issue?

@btmnk hey, run pnpm openapi-ts-tests test:update to update snapshots. Can you also add this change to the Next.js client and possibly Axios/Nuxt if they have the same issue?

It seems the pnpm openapi-ts-tests test:update command does not generate or update any files.. The tests itself also all run successfully (except for the performance test but that could be just my machine that's too slow).

I checked the other clients for type errors with ts-reset as well but only client-next hat the same issue. I updated it there as well.

nvm. Forgot to build after doing the changes in the client.ts. Now I was able to reproduce the failed tests.

After running the build command it did a change in an angular.json file. If that should not be included let me know and I'll remove it from the PR. Not sure why it did that for me..

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2290

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2290

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2290

commit: 4a77615

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 24.01%. Comparing base (7df6059) to head (4a77615).
Report is 4 commits behind head on main.

@@            Coverage Diff             @@
##             main    #2290      +/-   ##
==========================================
- Coverage   24.01%   24.01%   -0.01%     
==========================================
  Files         314      314              
  Lines       28949    28953       +4     
  Branches     1227     1227              
==========================================
  Hits         6953     6953              
- Misses      21987    21991       +4     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.