Run & review this pull request in StackBlitz Codeflow.

🦋 Changeset detected

Latest commit: 7a740ed

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

The latest updates on your projects. Learn more about Vercel for Git ↗︎

I have never worked with test snapshots before, but I feel like I am not supposed to edit these files manually? Any guidance on how to update the tests so that they parse would be appreciated!

@Daschi1 just need to run pnpm openapi-ts-tests test:update :)

@Daschi1 just need to run pnpm openapi-ts-tests test:update :)

When I run the command, I get an error:

pnpm openapi-ts-tests test:update

> openapi-ts-monorepo@0.1.0 openapi-ts-tests D:\Projects\openapi-ts
> turbo run $1 --filter="@test/openapi-ts" "test:update"

turbo 2.5.4

  x Missing tasks in project
  `->   x Could not find task `$1` in project

 ELIFECYCLE  Command failed with exit code 1.

Could you please help? I am not familiar with turbo and don't really know how to approach diagnosing this.

Hmm I actually haven't seen this error before, it's not very descriptive obviously. The only thing I know you could run into is the need to build the packages first (custom-client and openapi-ts), but I'd expect the error to say as much. If building packages doesn't help and you can't figure out what's the issue quickly let me know and I'll get this change in and fix the snapshots on my end

Hmm I actually haven't seen this error before, it's not very descriptive obviously. The only thing I know you could run into is the need to build the packages first (custom-client and openapi-ts), but I'd expect the error to say as much. If building packages doesn't help and you can't figure out what's the issue quickly let me know and I'll get this change in and fix the snapshots on my end

I investigated a bit and I think the error stems from the fact that pnpm somehow didn't correctly substitute test:update into $1 for the openapi-ts-tests script in package.json.

So I just ran the command directly (turbo run test:update --filter="@test/openapi-ts"), which initially exited early with some other errors. I then tried building the project, which also threw some errors. Eventually, the command just hung at some point, and after waiting a few minutes, I terminated it.

I ran the turbo command again, and it still didn't complete, and threw some errors and then hung again. (I feel like there might be something wrong with my local copy? 😅)

Somewhere along the process however, the necessary snapshot files appear to have been updated.

Could you please check and confirm that those files are indeed the ones we need?

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2192

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2192

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2192

commit: 7a740ed

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 24.96%. Comparing base (eb4fb3b) to head (7a740ed).
Report is 5 commits behind head on main.

@@           Coverage Diff           @@
##             main    #2192   +/-   ##
=======================================
  Coverage   24.96%   24.96%           
=======================================
  Files         296      296           
  Lines       27636    27636           
  Branches     1246     1246           
=======================================
  Hits         6899     6899           
  Misses      20729    20729           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Daschi1 tests passed, so the answer is yes! Thank you for contributing! I'll release this either today or tomorrow