fix: zod; handle array union types #2159

Joshua-hypt · 2025-06-11T11:53:35Z

Fixes #2157

bolt-new-by-stackblitz · 2025-06-11T11:53:37Z

Run & review this pull request in StackBlitz Codeflow.

changeset-bot · 2025-06-11T11:53:39Z

🦋 Changeset detected

Latest commit: 99ae4de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@hey-api/openapi-ts	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-06-11T11:53:39Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
hey-api-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 11, 2025 1:36pm

packages/openapi-ts/src/plugins/zod/plugin.ts

.changeset/popular-apples-fail.md

mrlubos · 2025-06-11T12:00:00Z

packages/openapi-ts/src/plugins/zod/plugin.ts

-      // TODO: parser - handle union
-      // return compiler.typeArrayNode(compiler.typeUnionNode({ types: itemExpressions }));
+      if (schema.logicalOperator === 'or') {
+        arrayExpression = compiler.callExpression({


As long as the tests pass this looks good but please add a test like this https://github.com/hey-api/openapi-ts/blob/main/packages/openapi-ts-tests/test/spec/3.1.x/validators-union-merge.json

You can either tack on another schema to that file or create a separate file altogether and add a new test case. Run pnpm openapi-ts-tests test:update to update snapshots once you've done either of these approaches

All done! I updated the test you shared with me a bit.

pkg-pr-new · 2025-06-11T12:00:10Z

Open in StackBlitz

@hey-api/client-axios

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-axios@2159

@hey-api/client-fetch

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-fetch@2159

@hey-api/client-next

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-next@2159

@hey-api/client-nuxt

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-nuxt@2159

@hey-api/nuxt

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2159

@hey-api/openapi-ts

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2159

@hey-api/vite-plugin

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2159

commit: 99ae4de

codecov · 2025-06-11T12:00:17Z

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 22.49%. Comparing base (01134c5) to head (99ae4de).
Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/openapi-ts/src/plugins/zod/plugin.ts	0.00%	14 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2159      +/-   ##
==========================================
- Coverage   22.49%   22.49%   -0.01%     
==========================================
  Files         273      273              
  Lines       25496    25504       +8     
  Branches      950      950              
==========================================
  Hits         5736     5736              
- Misses      19754    19762       +8     
  Partials        6        6

Flag	Coverage Δ
unittests	`22.49% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…timize)

Co-authored-by: Lubos <lmenus@lmen.us>

mrlubos · 2025-06-11T12:37:01Z

@Joshua-hypt I'm not on a computer but see a lot of snapshot changes. Did you verify they're all correct?

packages/openapi-ts-tests/test/__snapshots__/3.0.x/plugins/zod/default/zod.gen.ts

mrlubos

I think it looks good now! Assuming you want to remove the comment let's do that and it can be released

mrlubos · 2025-06-11T13:15:45Z

packages/openapi-ts/src/plugins/zod/plugin.ts

          }),
        ],
+
+        // compiler.callExpression({


Is this a dead code?

🤦 my bad

mrlubos

Thank you!

fix: zod; handle array union types

b4217bf

Joshua-hypt mentioned this pull request Jun 11, 2025

Zod schema generates unknown for union type #2157

Closed

vercel bot deployed to Preview June 11, 2025 11:54 View deployment

add changeset

87b2d6c

vercel bot deployed to Preview June 11, 2025 11:57 View deployment

github-advanced-security bot found potential problems Jun 11, 2025

View reviewed changes

packages/openapi-ts/src/plugins/zod/plugin.ts Fixed Show fixed Hide fixed

mrlubos requested changes Jun 11, 2025

View reviewed changes

Joshua-hypt and others added 2 commits June 11, 2025 14:00

fix: remove useless if statement and unreachable return statement (op…

e778b55

…timize)

Update .changeset/popular-apples-fail.md

fad31eb

Co-authored-by: Lubos <lmenus@lmen.us>

vercel bot deployed to Preview June 11, 2025 12:03 View deployment

fix: update tests

474bdb4

vercel bot deployed to Preview June 11, 2025 12:24 View deployment

Joshua-hypt requested a review from mrlubos June 11, 2025 12:36

mrlubos reviewed Jun 11, 2025

View reviewed changes

packages/openapi-ts-tests/test/__snapshots__/3.0.x/plugins/zod/default/zod.gen.ts Outdated Show resolved Hide resolved

fix: wrap arrayExpression in z.array()

f7af6d4

vercel bot deployed to Preview June 11, 2025 13:10 View deployment

Joshua-hypt requested a review from mrlubos June 11, 2025 13:11

mrlubos reviewed Jun 11, 2025

View reviewed changes

Joshua-hypt requested a review from mrlubos June 11, 2025 13:34

fix: remove dead code

99ae4de

vercel bot deployed to Preview June 11, 2025 13:36 View deployment

mrlubos approved these changes Jun 11, 2025

View reviewed changes

mrlubos merged commit 66fecce into hey-api:main Jun 11, 2025
15 of 17 checks passed

github-actions bot mentioned this pull request Jun 11, 2025

Version Packages #2160

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: zod; handle array union types #2159

fix: zod; handle array union types #2159

Uh oh!

Joshua-hypt commented Jun 11, 2025 •

edited

Loading

Uh oh!

bolt-new-by-stackblitz bot commented Jun 11, 2025

Uh oh!

changeset-bot bot commented Jun 11, 2025 •

edited

Loading

Uh oh!

vercel bot commented Jun 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

mrlubos Jun 11, 2025

Uh oh!

Joshua-hypt Jun 11, 2025

Uh oh!

pkg-pr-new bot commented Jun 11, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jun 11, 2025 •

edited

Loading

Uh oh!

mrlubos commented Jun 11, 2025

Uh oh!

Uh oh!

mrlubos left a comment

Uh oh!

mrlubos Jun 11, 2025

Uh oh!

Joshua-hypt Jun 11, 2025

Uh oh!

mrlubos left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix: zod; handle array union types #2159

fix: zod; handle array union types #2159

Uh oh!

Conversation

Joshua-hypt commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bolt-new-by-stackblitz bot commented Jun 11, 2025

Uh oh!

changeset-bot bot commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mrlubos Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

Joshua-hypt Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new bot commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mrlubos commented Jun 11, 2025

Uh oh!

Uh oh!

mrlubos left a comment

Choose a reason for hiding this comment

Uh oh!

mrlubos Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

Joshua-hypt Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

mrlubos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Joshua-hypt commented Jun 11, 2025 •

edited

Loading

changeset-bot bot commented Jun 11, 2025 •

edited

Loading

vercel bot commented Jun 11, 2025 •

edited

Loading

pkg-pr-new bot commented Jun 11, 2025 •

edited

Loading

codecov bot commented Jun 11, 2025 •

edited

Loading