feat: remove support for client packages #2172
Conversation
|
|
🦋 Changeset detectedLatest commit: cfc0abb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2172 +/- ##
==========================================
+ Coverage 22.49% 24.80% +2.31%
==========================================
Files 273 293 +20
Lines 25634 27595 +1961
Branches 950 1242 +292
==========================================
+ Hits 5766 6845 +1079
- Misses 19862 20742 +880
- Partials 6 8 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if (config.key) { | ||
| const field = map.get(config.key)!; | ||
| const name = field.map || config.key; | ||
| (params[field.in] as Record<string, unknown>)[name] = arg; |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
|
|
||
| if (field) { | ||
| const name = field.map || key; | ||
| (params[field.in] as Record<string, unknown>)[name] = value; |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
727ccd8 to
ba08fb3
Compare
| @@ -2,11 +2,11 @@ | |||
| import path from 'node:path'; | |||
|
|
|||
| // @ts-ignore | |||
| import { customClientPlugin } from '@hey-api/client-custom/plugin'; | |||
| import { customClientPlugin } from '@hey-api/custom-client/plugin'; | |||
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note test
ba08fb3 to
f2cf721
Compare
f2cf721 to
cfc0abb
Compare
|
Hi @mrlubos, after updating to @hey-api/openapi-ts@0.73.0, I noticed that the @hey-api/client-* packages are now added directly into the codebase. This seems to allow for faster installation in most cases—thank you for that! However, the source code under client/* and core/* is causing type errors with my current project settings, which prevents me from bundling it. While I could resolve this by modifying my tsconfig.json, I’d prefer to avoid potential side effects without fully verifying them. Would it be possible to include pre-bundled client.js and client.d.ts files for each @hey-api/client-* package? |
|
@johnny-mh Can you open a new issue with your tsconfig? I'll fix the types/errors so you'd be able to build the client yourself |
|
@mrlubos I moved the generated files to another package in my monorepo and copied the openapi-ts/tsconfig.json file. After that, everything built successfully without type errors. I believe that if you change your code to match my tsconfig.json, other projects might run into the same issue. I’ll open an issue if I encounter any other problems. Thanks again! |
|
Please open an issue with your config anyway! |
|
Okay I’ll open issue tomorrow |
|
Is there still a possibility to keep using the packages? We now have the |
|
Yeah, I was very reluctant to upgrade past this version. To echo @KiwiKilian , in our use case, we generate multiple clients which would lead to a lot of duplicated code. We need some way to allow for multiple generated clients to share the same core code. Not to mention that I'm not really a fan of having all this generated core code in our codebase, id much rather it live in the package like it used to... but I could look past that if this issue is fixed. |
|
@kylecarhart definitely feel free to not upgrade and stay pinned on an older version! But please, please let me know why so I can figure out a way to make both you and me happy with these features 🤝 I'll get to these clients again, it's on my radar |
Closes #1969
Closes #1821
Closes #1660