feat(client): better handle content types #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
=======================================
Coverage 90.70% 90.70%
=======================================
Files 66 66
Lines 4000 4000
Branches 477 477
=======================================
Hits 3628 3628
Misses 371 371
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mrlubos
reviewed
Mar 31, 2024
| export const getRequestBody = (options: ApiRequestOptions): unknown => { | ||
| if (options.body) { | ||
| if (options.mediaType?.includes('/json')) { | ||
| if (options.mediaType?.includes('application/json') || options.mediaType?.includes('+json')) { |
Member
There was a problem hiding this comment.
Why not make this just endsWith('json')?
Contributor
Author
There was a problem hiding this comment.
It may not always end with json, as there may be charset information in the header. JSON with always be application/json or something/something+json (but may be appended by "; charset=utf8")
Member
There was a problem hiding this comment.
How about includes json then? Why not drop + and /?
mrlubos
approved these changes
Mar 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better handle more content types based on: https://www.iana.org/assignments/media-types/media-types.xhtml
ref: #152 (
pdfcontent type as binary)