这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(api): add experimental flag #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2024
Merged

fix(api): add experimental flag #191

merged 1 commit into from
Mar 30, 2024

Conversation

@mrlubos
Copy link
Member

@mrlubos mrlubos commented Mar 30, 2024

Closes #179

@mrlubos mrlubos requested a review from jordanshatford March 30, 2024 16:43
@mrlubos mrlubos marked this pull request as ready for review March 30, 2024 16:43
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 30, 2024
View reviewed changes
src/templates/partials/dataDestructure.hbs
{{/if}}
{{#each parameters}}
{{#if @root.$config.experimental}}
{{#notEquals in 'query'}}

Check warning

Code scanning / CodeQL

Implicit operand conversion

This expression will be implicitly converted from string to object.
@codecov
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 13.72549% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 90.80%. Comparing base (3921a57) to head (a2f521e).

Files Patch % Lines
src/utils/handlebars.ts 10.20% 44 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
- Coverage   91.80%   90.80%   -1.01%     
==========================================
  Files          66       66              
  Lines        3941     3990      +49     
  Branches      477      477              
==========================================
+ Hits         3618     3623       +5     
- Misses        322      366      +44     
  Partials        1        1
Flag Coverage Δ
unittests 90.80% <13.72%> (-1.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit 1def4fa into main Mar 30, 2024
@mrlubos mrlubos deleted the fix/options-experimental branch March 30, 2024 16:48
@github-actions github-actions bot mentioned this pull request Mar 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jordanshatford jordanshatford Awaiting requested review from jordanshatford

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add experimental client

2 participants

@mrlubos