feat: file or blob #186
Merged
feat: file or blob #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
=======================================
Coverage 91.84% 91.84%
=======================================
Files 66 66
Lines 3935 3935
Branches 476 476
=======================================
Hits 3614 3614
Misses 320 320
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mrlubos
reviewed
Mar 30, 2024
| /^(Blob|File)$/.test(value.constructor.name) && | ||
| /^(Blob|File)$/.test(value[Symbol.toStringTag]) | ||
| ); | ||
| return value instanceof Blob; |
Member
There was a problem hiding this comment.
Possible to inline this call wherever it's used instead of having a separate function? It's so straightforward now that we don't need a wrapper function around it...
mrlubos
approved these changes
Mar 30, 2024
3659a91 to
3d18aae
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE:
Blobclass is fully supported Node 18+ meaning we directly check value instanceof Blob. And because File extends Blob, File instanceof Blob === true.