fix: various angular client fixes #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
=======================================
Coverage 91.91% 91.92%
=======================================
Files 66 66
Lines 3947 3949 +2
Branches 476 476
=======================================
+ Hits 3628 3630 +2
Misses 318 318
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
947dc08 to
3fc70da
Compare
jordanshatford
commented
Mar 28, 2024
mrlubos
reviewed
Mar 28, 2024
Member
mrlubos
left a comment
There was a problem hiding this comment.
When removing stuff like the cancelable promise, what's that based on? Why was it removed?
Contributor
Author
It's not actually used in the angular client. It returns Observables instead |
Contributor
Author
|
@mrlubos is this ok to be merged? |
mrlubos
approved these changes
Mar 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.