这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@max-scopp
Copy link
Contributor

@max-scopp max-scopp commented Oct 31, 2024

Closes #1072
This PR introduces preliminary support for Angular Query Experimental, functioning similarly to the existing React Query plugin.

Reasoning

We’re exploring ways to integrate @hey-api at work, but legacy Angular support is a significant barrier. This PR aims to offer an initial foundation for community collaboration and feedback. While this topic isn’t on a fast-tracked timeline internally, the basic implementation here is meant to initiate development in this direction.

Next Steps

I'm happy to extend examples and provide continued support for this PR, with the ultimate goal of making it merge-ready. The hope is that this initial setup can evolve with community input, building Angular support that meets the needs of various projects.

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 9:03am

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2024

⚠️ No Changeset found

Latest commit: f40c8c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, appreciate the effort @max-scopp! I think you'll want to update snapshots with pnpm openapi-ts test:update, the rest looks good to me. We can coordinate on documentation and examples on Discord if you want?

@max-scopp
Copy link
Contributor Author

I just got myself a glass of rum to celebrate! I haven't found a discord server link, but you can find me under "maxscopp" on Discord and we can discuss the rest.

Thanks for the insanely fast response!

@codecov
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 89.13043% with 5 lines in your changes missing coverage. Please review.

Project coverage is 73.19%. Comparing base (13e0065) to head (f40c8c8).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...ins/@tanstack/angular-query-experimental/config.ts 86.95% 3 Missing ⚠️
.../src/plugins/@tanstack/query-core/plugin-legacy.ts 85.71% 1 Missing ⚠️
...napi-ts/src/plugins/@tanstack/query-core/plugin.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1218      +/-   ##
==========================================
+ Coverage   73.15%   73.19%   +0.03%     
==========================================
  Files         125      127       +2     
  Lines       17662    17706      +44     
  Branches     1732     1732              
==========================================
+ Hits        12921    12960      +39     
- Misses       4738     4743       +5     
  Partials        3        3              
Flag Coverage Δ
unittests 73.19% <89.13%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit e517332 into hey-api:main Nov 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Angular client

2 participants