fix(bitfield): respect 32 bit targets #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
we should maybe remove the usize impls in the next breaking change, i agree that they may not really be worth the effort — who's actually going to use them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personally, I'd just not allow
usizeat all, but since it already is, we should at least support 16 bit targets...I've rearranged primitive
FromBitsimpls so that it's [clear that]impl FromBits<T> for {u,i}sizeis only supported on platforms withsize_of::<usize>() <= size_of::<T>()impl FromBits<{u,i}size> for Tis only supported on platforms withsize_of::<T>() <= size_of::<usize>()