feat(maitake-sync): add spin::RwLock
#472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the non-`loom` test wrappers would eat logs from spawned threads, because the thread-local `tracing` subscriber was not propagated correctly.
This commit adds a synchronous `RwLock` spinlock to `maitake_sync::spin`. Closes #470
hawkw
added a commit
that referenced
this pull request
Jan 27, 2024
This fixes an issue where the non-`loom` test wrappers would eat logs from spawned threads, because the thread-local `tracing` subscriber was not propagated correctly.
hawkw
added a commit
that referenced
this pull request
Jan 27, 2024
hawkw
added a commit
that referenced
this pull request
Jan 27, 2024
hawkw
added a commit
that referenced
this pull request
Jan 27, 2024
This commit adds `Default` impls to `Mutex`, `RwLock`, and `spin::Mutex` where `T: Default`, allowing locked data to be constructed through `Default` without needing `Mutex::new(Default::default())` or similar. An implementation of `Default` for `spin::RwLock` was not added, because I already did that in #472.
hawkw
added a commit
that referenced
this pull request
Jan 27, 2024
This commit adds `Default` impls to `Mutex`, `RwLock`, and `spin::Mutex` where `T: Default`, allowing locked data to be constructed through `Default` without needing `Mutex::new(Default::default())` or similar. An implementation of `Default` for `spin::RwLock` was not added, because I already did that in #472.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a synchronous
RwLockspinlock tomaitake_sync::spin.