feat(maitake): introduce a separate maitake-sync crate
#462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmunns
added a commit
that referenced
this pull request
Apr 3, 2025
Updated changelog, bumped version number. Changes sourced from https://github.com/hawkw/mycelium/commits/main/cordyceps. Omitted minor changes from #462 and #463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
maitakecrate provides async synchronization primitives in amaitake::syncmodule. These APIs don't require the rest of theruntime, and would be nice to be able to use in other crates.
maitakeis not yet published to crates.io, as it contains Git-only dependencies.
However, the
syncmodule can be implemented entirely using publishedcode, and therefore, a crate containing only
maitake::synccould bepublished.
This branch introduces a new
maitake-synccrate, containing thesynchronization primitives from
maitake::sync. Themaitake::syncmodule now re-exports
maitake-sync, so there should be no impact forexisting uses of the crate. The new
maitake-synccrate can easily bepublished to crates.io, and depended on from released code.