这是indexloc提供的服务,不要输入任何密码
Skip to content

Chore: Fix issues with feedback components visibilty #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

robertjdominguez
Copy link
Collaborator

Description 📝

• Fixed low-contrast text colors in feedback component that were making content difficult to read
• Resolved dark background input fields appearing in light mode
• Improved dark mode textarea visibility by adding proper contrast

Previously, the feedback section was using hardcoded neutral colors that created accessibility issues:

.form h3 {
  color: var(--primary-neutral-200); /* Too light */
}

.form input,
.form textarea {
  color: var(--primary-neutral-200);
  background-color: var(--primary-dark); /* Black bg in light mode */
}

.textAreaLabel p {
  color: var(--primary-neutral-300); /* Very light gray */
}

Light Mode
image

Dark Mode
image

Now we're using semantic color variables that adapt properly to both themes:

.form h3 {
  color: var(--heading-color); /* Theme-aware heading color */
}

.form input,
.form textarea {
  color: var(--heading-color);
  background-color: var(--main-bg-color); /* White in light, dark in dark */
}

html[data-theme='dark'] .form input,
html[data-theme='dark'] .form textarea {
  border: 1px solid var(--primary-neutral-600);
  background-color: var(--primary-neutral-800);
  color: var(--primary-neutral-200);
}

Light Mode
image

Dark Mode
image

The changes ensure proper contrast ratios for accessibility compliance while maintaining visual hierarchy. Text inputs now have appropriate backgrounds in both light and dark modes, and all text elements use semantic color variables that provide sufficient contrast against their backgrounds. You know, like they should.

@robertjdominguez robertjdominguez requested a review from manasag July 25, 2025 19:40
@hasura-bot
Copy link
Collaborator

@robertjdominguez Thanks for your PR! I've assigned @robertjdominguez to review it.

@robertjdominguez robertjdominguez enabled auto-merge (squash) July 25, 2025 19:44
@robertjdominguez robertjdominguez merged commit 70c26bd into main Jul 25, 2025
4 checks passed
@robertjdominguez robertjdominguez deleted the robdominguez/doc-3026-improve-visibility-of-feedback-section-text-in-documentation branch July 25, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants