add aggregate expression types to fixture metadata #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallettj
commented
Aug 8, 2024
Comment on lines
+71
to
+74
| aggregatedType: Int | ||
| aggregationFunctions: | ||
| - name: _avg | ||
| returnType: Int |
There was a problem hiding this comment.
The return type for averages over Int should be Float. We need to fix that in the connector capabilities. I filed an issue to follow up on this, https://linear.app/hasura/issue/NDC-385/return-type-for-average-of-ints-should-be-float-not-int
daniel-chambers
approved these changes
Aug 9, 2024
dmoverton
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once again, this only affects integration tests and the local dev environment.
Adds aggregation expression types for everything that looks it should be aggregatable. The connector isn't advertising support for nested field aggregates yet so the nested field aggregates are commented out for now. I filed NDC-386 to follow up on that. Everything looks good in ad-hoc testing. I'm planning to follow up with integration tests shortly.
Completes NDC-381