这是indexloc提供的服务,不要输入任何密码
Skip to content

switch sample_mflix fixture config to use new boolean expression metadata #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 8, 2024

Conversation

hallettj
Copy link
Collaborator

@hallettj hallettj commented Aug 2, 2024

These changes only affect integration tests and the preconfigured dev environment. The fixture metadata configures two MongoDB connectors: one using MongoDB's sample_mlfix sample data set, the other using a Chinook data set.

Updates object types and scalar types in metadata configuration for both connectors to use BooleanExpressionType instead of ObjectBooleanExpressionType.

I also moved the scalar type metadata so that it is shared between the sample_mflix and chinook connectors. Now we are using the same set of scalar types with both connectors instead of having Chinook_ -prefixed types for the chinook connector.

References NDC-381

@hallettj hallettj self-assigned this Aug 2, 2024
@hallettj hallettj marked this pull request as draft August 2, 2024 21:30
@hallettj hallettj marked this pull request as ready for review August 6, 2024 23:17
Copy link
Contributor

@dmoverton dmoverton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hallettj hallettj merged commit 888162e into main Aug 8, 2024
1 check passed
@hallettj hallettj deleted the jesse/update-fixtures-for-bool-exp branch August 8, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants