Update to ndc-spec v0.1.5 and ndc-sdk-rs v0.2.1 #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallettj
approved these changes
Jul 11, 2024
| @@ -69,13 +69,15 @@ impl From<Type> for ndc_models::Type { | |||
| // ExtendedJSON can respresent any BSON value, including null, so it is always nullable | |||
| Type::ExtendedJSON => ndc_models::Type::Nullable { | |||
| underlying_type: Box::new(ndc_models::Type::Named { | |||
| name: mongodb_support::EXTENDED_JSON_TYPE_NAME.to_owned(), | |||
| name: mongodb_support::EXTENDED_JSON_TYPE_NAME.to_owned().into(), | |||
There was a problem hiding this comment.
I think for cases like this we might avoid heap allocation with something like,
TypeName(SmolStr::new_static(mongodb_support::EXTENDED_JSON_TYPE_NAME))That would be a bit easier if the ndc-models newtype macro added implementations for From SmolStr or From &'static str. But it looks like the ref-cast crate helps to fill that gap?
This is absolutely not worth you spending time on making changes. I'm commenting only because I enjoy the allocation golf thought exercises.
| @@ -28,7 +28,7 @@ impl AggregationFunction { | |||
| all::<AggregationFunction>() | |||
| .find(|variant| variant.graphql_name() == s) | |||
| .ok_or(QueryPlanError::UnknownAggregateFunction { | |||
| aggregate_function: s.to_owned(), | |||
| aggregate_function: s.to_owned().into(), | |||
There was a problem hiding this comment.
It looks like we should at least add a From &'a str to newtype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Update to latest ndc-spec and sdk