Relax type requirements for primary uniqueness constraint #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…niqueness constraint
| schema::Type::Scalar(BsonScalarType::ObjectId) => Some(()), | ||
| _ => None, | ||
| }?; | ||
| let _id_field = object_type.fields.get("_id")?; |
There was a problem hiding this comment.
Shouldn't this be validated to at least be a scalar type (and shouldn't it only be scalar types with equality?)?
What's the behaviour if the _id column is an object type? Does that break in v3-engine?
There was a problem hiding this comment.
MongoDB itself doesn't care. The _id can have any type and all types are comparable. However, I don't want to potentially break the engine, so I've modified it to only allow scalar types for which we define an equality operator in the capabilities.
codedmart
approved these changes
Jun 13, 2024
hallettj
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't require _id field to have type ObjectId when generate primary uniqueness constraint
Type
(Select only one. In case of multiple, choose the most appropriate)