unify double and int types to double in cli introspection #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if we saw a mixture of
int
anddouble
values in the same field in different documents in a collection we would infer theExtendedJSON
type for that field. This PR changes that behavior to inferdouble
.We could extend this to unify other compatible numeric types:
int
→long
int
→decimal
double
→decimal
long
→decimal
For now I've stuck with
int
→double
because we have special handling anbson_to_json
to accept a value of one type where the other is expected. We'll have to add similar special handling to support unifying the other numeric types.MDB-128