fix order of results for query requests with more than 10 variable sets #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallettj
commented
Apr 14, 2024
| let pipelines_with_response_shapes: BTreeMap<String, (Pipeline, ResponseShape)> = foreach | ||
| let pipelines_with_response_shapes: Vec<(String, (Pipeline, ResponseShape))> = foreach |
There was a problem hiding this comment.
This PR contains a lot of fixture and test changes. This line is the only change required for the actual fix.
| @@ -160,8 +161,6 @@ impl Connector for MongoConnector { | |||
| let response = handle_query_request(state, v2_request) | |||
| .await | |||
| .map_err(mongo_agent_error_to_query_error)?; | |||
| let r = v2_to_v3_query_response(response); | |||
| tracing::warn!(v3_response = %serde_json::to_string(&r).unwrap()); | |||
There was a problem hiding this comment.
This fixes some debugging output I accidentally committed in a previous PR. I'd like to set up the sdk to making the logging level for this crate configurable so that I don't have to change debug!s to warn!s to see these traces.
dmoverton
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
In query requests with more than 10 variable sets results were sent back in the wrong order because facet fields were put into a
BTreeMapwhich sorted them lexicographically. This PR switches to aVecof tuples to preserve expected order.While working on this I updated the dev services to run two connectors with a remote relationship configured. If you run
arion up -dyou can access GraphiQL at http://localhost:7100/ and test the fix with a query like this one:The remote relationship matches
albumIdin theAlbumcollection of the chinook database with theruntimefield in themoviescollection of the sample_mflix database. It's not a sensical relationship but it gives us something to test with since both of those fields are ints with plenty of values that line up.Issue ticket number and link
MDB-111