Fix collection schemas not having a unique constraint for the _id column
#32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sordina
approved these changes
Apr 8, 2024
| @@ -6,6 +6,7 @@ This changelog documents the changes between release versions. | |||
| - Fix bug in v2 to v3 conversion of query responses containing nested objects ([PR #27](https://github.com/hasura/ndc-mongodb/pull/27)) | |||
| - Fixed bug where use of aggregate functions in queries would fail ([#26](https://github.com/hasura/ndc-mongodb/pull/26)) | |||
| - Rename Any type to ExtendedJSON to make its representation clearer ([#30](https://github.com/hasura/ndc-mongodb/pull/30)) | |||
| - The collection primary key `_id` property now has a unique constraint generated in the NDC schema for it ([#32](https://github.com/hasura/ndc-mongodb/pull/32)) | |||
Comment on lines
+90
to
+108
| fn get_primary_key_uniqueness_constraint(object_types: &BTreeMap<String, models::ObjectType>, name: &str, collection: &schema::Collection) -> Option<(String, models::UniquenessConstraint)> { | ||
| // Check to make sure our collection's object type contains the _id objectid field | ||
| // If it doesn't (should never happen, all collections need an _id column), don't generate the constraint | ||
| let object_type = object_types.get(&collection.r#type)?; | ||
| let id_field = object_type.fields.get("_id")?; | ||
| match &id_field.r#type { | ||
| models::Type::Named { name } => { | ||
| if *name == BsonScalarType::ObjectId.graphql_name() { Some(()) } else { None } | ||
| }, | ||
| models::Type::Nullable { .. } => None, | ||
| models::Type::Array { .. } => None, | ||
| models::Type::Predicate { .. } => None, | ||
| }?; | ||
| let uniqueness_constraint = models::UniquenessConstraint { | ||
| unique_columns: vec!["_id".into()] | ||
| }; | ||
| let constraint_name = format!("{}_id", name); | ||
| Some((constraint_name, uniqueness_constraint)) | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schema endpoint was not listing a unique constraint for collections that captured the
_idcolumn that every Mongo table must have that is the primary key of the table.It now generates a unique constraint named
<collection name>_idfor that column, so long as the table's object type indicates the presence of an_idcolumn of type object id. That should always be the case, but if it's missing for some (bad) reason, we just omit the unique constraint too.The test configuration in
fixtures/connector/chinookhas been updated to fix the_idcolumns being nullable, which they aren't._idmust always have a value.