Avoid (incorrectly) deserializing already serialized v2 query response #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallettj
approved these changes
Apr 4, 2024
hallettj
added a commit
that referenced
this pull request
Apr 12, 2024
The change in #27 fixed serializing query responses with object values, but serializing foreach responses stopped working. This PR switches back to roughly the logic in which foreach responses were working, and fixes the issue with object values in a different way. This is a quick patch - we still need to rework response serialization to use `bson_to_json` translation. That will require using the query request to direct response serialization which should make everything more robust. I removed the use of `JsonResponse` in this PR because it serves no purpose for this connector. `JsonResponse` is useful for connectors that get a JSON response from the database, which the connector can pass through without processing. But as far as we can determine MongoDB always sends BSON so to get JSON output we're stuck doing response processing in the connector. There's also a fix in here to avoid using `$literal` expression escaping in a context where expressions are not evaluated. Fixes https://hasurahq.atlassian.net/browse/MDB-19 --------- Co-authored-by: Brandon Martin <brandon@codedmart.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid deserializing the serialized query response back into a v2
QueryReponse. This was broken because the deserializer does not have enough information to differentiate between object-valued fields and relations.The reason we were deserializing the v2 response was so that we could convert it into a v3
QueryResponse. Fortunately, it is not necessary to do this. The v2 and v3 query responses have almost the same JSON representation. The only difference is that in v3 the response is returned within a (singleton) array.Therefore, rather than fully deserializing to a v2
QueryResponse, all we need to do is deserialize to a JSON value, wrap it in an array and serialize again.