这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix default config directory and port #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2024
Merged

Fix default config directory and port #20

merged 1 commit into from
Mar 28, 2024

Conversation

dmoverton
Copy link
Contributor

Describe your changes

Set default config directory and port to conform to https://github.com/hasura/ndc-hub/blob/main/rfcs/0000-deployment.md

@dmoverton dmoverton self-assigned this Mar 28, 2024
daniel-chambers
daniel-chambers approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@daniel-chambers daniel-chambers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, but I don't really understand the Nix stuff enough to know if there might be a consequence elsewhere for doing this. I don't think so, because otherwise I'd expect to see that path mentioned elsewhere too, and it isn't.

@dmoverton dmoverton merged commit b50e26c into main Mar 28, 2024
@dmoverton dmoverton deleted the dmoverton/fix/default-config-dir branch March 28, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-chambers daniel-chambers daniel-chambers approved these changes

@hallettj hallettj Awaiting requested review from hallettj

Assignees

@dmoverton dmoverton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmoverton @daniel-chambers