这是indexloc提供的服务,不要输入任何密码
Skip to content

Change generated query logs to info level #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

danieljharvey
Copy link
Contributor

These are helpful for users.

@danieljharvey danieljharvey requested a review from hallettj May 8, 2025 15:44
Copy link
Collaborator

@hallettj hallettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason this was at debug is because the pipeline will include user-entered query values, like values used in filter comparisons. I thought there might be some possible scenario where there might be sensitive data in there. But maybe that is too paranoid; and being able to see pipelines does seem very useful.

@danieljharvey
Copy link
Contributor Author

The reason this was at debug is because the pipeline will include user-entered query values, like values used in filter comparisons. I thought there might be some possible scenario where there might be sensitive data in there. But maybe that is too paranoid; and being able to see pipelines does seem very useful.

That's fair. Perhaps we should make this opt-in with a particular env var. Will have a think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants