skip system and unsample-able collections in introspection #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wrote an integration test for this, but since our integration test database runs without any security measures in place it was taking too long for me to reproduce the error. So no automated test. Sorry! |
daniel-chambers
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have had users unable to run introspection because sampling fails on an automatically-generated collection called
system.views. This collection is generated if the database has any views. On some deployments attempts to run aggregate (which is what introspection sampling uses) fail with a permissions error. We've seen this come up in MongoDB v6 running on Atlas.Collections prefixed with
system.are reserved for internal use. We shouldn't include them in introspection. https://www.mongodb.com/docs/manual/reference/system-collections/#synopsisThis PR makes two changes:
system., and log a warning