handle collection validators with object fields that do not list properties #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-chambers
approved these changes
Jan 16, 2025
Comment on lines
153
to
155
| Property::Object { | ||
| properties: None, .. | ||
| } => (vec![], Type::ExtendedJSON), |
There was a problem hiding this comment.
The meat of the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a collection validator species an property of type
object, but does not specify a list of nested properties for that object then we will infer theExtendedJSONtype for that property. For a collection created with this set of options would have the typeExtendedJSONfor itsreactionsfield:{ "validator": { "$jsonSchema": { "bsonType": "object", "properties": { "reactions": { "bsonType": "object" }, } } } }If the validator specifies a map of nested properties, but that map is empty, then we interpret that as an empty object type.