recreate supergraph fixture using latest cli version #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ); | ||
| Ok(()) | ||
| } | ||
| // This doesn't seem to work anymore in the latest engine version |
There was a problem hiding this comment.
This can be re-enabled if you put the CompatibilityConfig date back I believe?
There was a problem hiding this comment.
I tried setting CompatibilityConfig to an earlier date, and it didn't help so I'm removing this test. This functionality isn't supported until the next ndc-spec version anyway.
| @@ -10,9 +10,7 @@ | |||
| "fields": { | |||
| "Name": { | |||
| "type": { | |||
| "nullable": { | |||
There was a problem hiding this comment.
I am assuming this is expected?
There was a problem hiding this comment.
Yeah that's nothing to worry about
danieljharvey
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreates the supergraph in
fixtures/hasura/using ddn cli v2.15.0 with as little hand-editing of metadata as possible. This makes it much easier to continue updating metadata using the cli.This PR mainly affects the integration test and local development testing setup. But since I needed to update the GraphQL Engine version used in integration tests I updated flake inputs. That leads to updating the openssl version. And since all of that leads to rebuilding stuff anyway I also updated the Rust toolchain to v1.83.0.
An issue that came up is that the hack I had tested to filter by array fields does not seem to work anymore. It looks like this is because of a change in the engine - the relevant test fails with the previous metadata fixture with the latest engine version. I've disabled the test. This is the test query:
Note that
castis an array of strings. It looks like we may need to wait for ndc-spec v0.2 to be able to do this properly.The changes here include a lot of automatically-generated configuration in
fixtures/hasura/so it's a big set of changes.