support more query operators in native query pipeline type inference #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| match operator.as_ref() { | ||
| "$eq" => analyze_match_expression( | ||
| match operator.as_ref() { | ||
| "$and" | "$or" | "$nor" => { |
There was a problem hiding this comment.
So once again we hardcode every function we want to support? This does at least result in very concrete checking code.
4094237 to
0b52183
Compare
Base automatically changed from
jessehallett/eng-1102-support-more-aggregation-expression-operators-when
to
main
November 19, 2024 19:26
e9ee52a to
9ed82c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work an an in-progress feature that is gated behind a feature flag,
native-query-subcommandWhen generating configurations for native queries it is necessary to analyze operators in
$matchstages in aggregation pipelines to infer types for any parameters that appear in operator arguments.This PR adds the logic to process these operators:
$and|$or|$nor$not$elemMatch$eq|$ne|$gt|$lt|$gte|$lte$in|$nin$exists$type$mod$regex$all$sizeThe full set of available operators is given here: https://www.mongodb.com/docs/manual/reference/operator/query/