infer types for parameters based on usage when generating native query #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mongodb-expression-parser
hallettj
commented
Oct 23, 2024
Comment on lines
+308
to
+334
| #[googletest::test] | ||
| fn infers_native_query_from_pipeline_with_unannotated_parameter() -> googletest::Result<()> { | ||
| let config = mflix_config(); | ||
|
|
||
| let pipeline = Pipeline::new(vec![Stage::Match(doc! { | ||
| "title": { "$eq": "{{ title }}" }, | ||
| })]); | ||
|
|
||
| let native_query = native_query_from_pipeline( | ||
| &config, | ||
| "movies_by_title", | ||
| Some("movies".into()), | ||
| pipeline, | ||
| )?; | ||
|
|
||
| expect_that!( | ||
| native_query.arguments, | ||
| unordered_elements_are![( | ||
| displays_as(eq("title")), | ||
| field!( | ||
| ObjectField.r#type, | ||
| eq(&Type::Scalar(BsonScalarType::String)) | ||
| ) | ||
| )] | ||
| ); | ||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
This test demonstrates the magic
codedmart
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets the functionality in place - this change demonstrates detecting parameters and inferring types for parameters used in equality comparisons in a
$matchstage. It also detects parameters in aggregation expressions in any context, but does not infer types for those yet. We'll flesh type inference in more contexts as we flesh out support for more aggregation stages, operators, etc.All of this is still behind a feature flag,
native-query-subcommand. This work is still in development and isn't ready for stable use yet.