escape field names in relation mappings when necessary #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallettj
commented
Oct 8, 2024
Comment on lines
+899
to
+900
| #[tokio::test] | ||
| async fn filters_by_field_nested_in_object_in_related_collection() -> Result<(), anyhow::Error> |
There was a problem hiding this comment.
I found this ancient, forgotten test so I uncommented it.
Comment on lines
+70
to
+73
| // If there is a single column mapping, and the source and target field references can be | ||
| // expressed as match keys (we don't need to escape field names), then we can use a concise | ||
| // correlated subquery. Otherwise we need to fall back to an uncorrelated subquery. | ||
| let safe_single_column_mapping = if column_mapping.len() == 1 { |
There was a problem hiding this comment.
The meat of the changes starts here
…f-safe_name-to-produce-lookup-stages
…f-safe_name-to-produce-lookup-stages
daniel-chambers
approved these changes
Oct 8, 2024
crates/integration-tests/src/lib.rs
Outdated
| @@ -35,6 +36,12 @@ fn get_connector_chinook_url() -> anyhow::Result<Url> { | |||
| Ok(url) | |||
| } | |||
|
|
|||
| fn get_connector_test_cases_url() -> anyhow::Result<Url> { | |||
| let input = env::var(CONNECTOR_TEST_CASES_URL).map_err(|_| anyhow!("please set {CONNECTOR_TEST_CASES_URL} to the the base URL of a running MongoDB connector instance"))?; | |||
There was a problem hiding this comment.
Suggested change
| let input = env::var(CONNECTOR_TEST_CASES_URL).map_err(|_| anyhow!("please set {CONNECTOR_TEST_CASES_URL} to the the base URL of a running MongoDB connector instance"))?; | |
| let input = env::var(CONNECTOR_TEST_CASES_URL).map_err(|_| anyhow!("please set {CONNECTOR_TEST_CASES_URL} to the base URL of a running MongoDB connector instance"))?; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously on attempts to join on field names that require escaping the request would fail with an error saying that a name was not valid. This change does the necessary escaping to make the join work.
This is the last change that was needed to get rid of
safe_namewhich was the quick-and-easy fail-on-problematic-names solution that we used early on.