这是indexloc提供的服务，不要输入任何密码
Skip to content

ci: run integration tests with MongoDB v8; remove MongoDB v5 from testing #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Oct 8, 2024
Merged

ci: run integration tests with MongoDB v8; remove MongoDB v5 from testing #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
295d678
emit an $addFields stage before $sort with safe aliases if necessary
hallettj Sep 27, 2024
ccf5bab
update changelog
hallettj Sep 27, 2024
20f1496
connector configuration for test_cases
hallettj Aug 29, 2024
d28a3b6
fix connector config
hallettj Aug 30, 2024
67849f5
update ColumnRef for OrderByTarget
hallettj Sep 3, 2024
81e808e
map scalar types to new connector
hallettj Sep 3, 2024
745c569
wip:
hallettj Sep 30, 2024
dbe1092
fix up merge
hallettj Sep 30, 2024
c675315
progress on separating query documents from aggregation expressions
hallettj Oct 2, 2024
a66de6a
created make_query_document which is simpler than attempting to backt…
hallettj Oct 3, 2024
4cb5364
Merge branch 'main' into jessehallett/eng-1020-nested-expressions-do-…
hallettj Oct 3, 2024
1a1d116
finish implementation of make_aggregation_expression
hallettj Oct 3, 2024
6f98702
fixes based on unit tests
hallettj Oct 3, 2024
c605197
add some integration tests
hallettj Oct 4, 2024
6526580
update changelog
hallettj Oct 4, 2024
b02ce6b
another test needs to be skipped in MongoDB 5
hallettj Oct 4, 2024
87f42c8
ci: run integration tests with MongoDB v8; remove MongoDB v5 from tes…
hallettj Oct 4, 2024
e69e394
Merge branch 'main' into jessehallett/eng-1159-mongodb-test-mongodb-v…
hallettj Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions crates/integration-tests/src/tests/aggregation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,17 +40,6 @@ async fn runs_aggregation_over_top_level_fields() -> anyhow::Result<()> {

#[tokio::test]
async fn aggregates_extended_json_representing_mixture_of_numeric_types() -> anyhow::Result<()> {
// Skip this test in MongoDB 5 because the example fails there. We're getting an error:
//
// > Kind: Command failed: Error code 5491300 (Location5491300): $documents' is not allowed in user requests, labels: {}
//
// This doesn't affect native queries that don't use the $documents stage.
if let Ok(image) = std::env::var("MONGODB_IMAGE") {
if image == "mongo:5" {
return Ok(());
}
}

assert_yaml_snapshot!(
graphql_query(
r#"
Expand Down Expand Up @@ -83,17 +72,6 @@ async fn aggregates_extended_json_representing_mixture_of_numeric_types() -> any

#[tokio::test]
async fn aggregates_mixture_of_numeric_and_null_values() -> anyhow::Result<()> {
// Skip this test in MongoDB 5 because the example fails there. We're getting an error:
//
// > Kind: Command failed: Error code 5491300 (Location5491300): $documents' is not allowed in user requests, labels: {}
//
// This doesn't affect native queries that don't use the $documents stage.
if let Ok(image) = std::env::var("MONGODB_IMAGE") {
if image == "mongo:5" {
return Ok(());
}
}

assert_yaml_snapshot!(
graphql_query(
r#"
Expand Down
11 changes: 0 additions & 11 deletions crates/integration-tests/src/tests/expressions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,6 @@ use crate::{connector::Connector, graphql_query, run_connector_query};

#[tokio::test]
async fn evaluates_field_name_that_requires_escaping_in_nested_expression() -> anyhow::Result<()> {
// Skip this test in MongoDB 5 because the example fails there. We're getting an error:
//
// > Kind: Command failed: Error code 5491300 (Location5491300): $documents' is not allowed in user requests, labels: {}
//
// This means that remote joins are not working in MongoDB 5
if let Ok(image) = std::env::var("MONGODB_IMAGE") {
if image == "mongo:5" {
return Ok(());
}
}

assert_yaml_snapshot!(
graphql_query(
r#"
Expand Down
22 changes: 0 additions & 22 deletions crates/integration-tests/src/tests/filtering.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,6 @@ use crate::{connector::Connector, graphql_query, run_connector_query};

#[tokio::test]
async fn filters_on_extended_json_using_string_comparison() -> anyhow::Result<()> {
// Skip this test in MongoDB 5 because the example fails there. We're getting an error:
//
// > Kind: Command failed: Error code 5491300 (Location5491300): $documents' is not allowed in user requests, labels: {}
//
// This doesn't affect native queries that don't use the $documents stage.
if let Ok(image) = std::env::var("MONGODB_IMAGE") {
if image == "mongo:5" {
return Ok(());
}
}

assert_yaml_snapshot!(
graphql_query(
r#"
Expand Down Expand Up @@ -76,17 +65,6 @@ async fn filters_by_comparisons_on_elements_of_array_of_scalars() -> anyhow::Res
#[tokio::test]
async fn filters_by_comparisons_on_elements_of_array_of_scalars_against_variable(
) -> anyhow::Result<()> {
// Skip this test in MongoDB 5 because the example fails there. We're getting an error:
//
// > Kind: Command failed: Error code 5491300 (Location5491300): $documents' is not allowed in user requests, labels: {}
//
// This doesn't affect native queries that don't use the $documents stage.
if let Ok(image) = std::env::var("MONGODB_IMAGE") {
if image == "mongo:5" {
return Ok(());
}
}

assert_yaml_snapshot!(
run_connector_query(
Connector::SampleMflix,
Expand Down
22 changes: 0 additions & 22 deletions crates/integration-tests/src/tests/native_query.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,6 @@ use ndc_test_helpers::{asc, binop, field, query, query_request, target, variable

#[tokio::test]
async fn runs_native_query_with_function_representation() -> anyhow::Result<()> {
// Skip this test in MongoDB 5 because the example fails there. We're getting an error:
//
// > Kind: Command failed: Error code 5491300 (Location5491300): $documents' is not allowed in user requests, labels: {}
//
// This doesn't affect native queries that don't use the $documents stage.
if let Ok(image) = std::env::var("MONGODB_IMAGE") {
if image == "mongo:5" {
return Ok(());
}
}

assert_yaml_snapshot!(
graphql_query(
r#"
Expand Down Expand Up @@ -55,17 +44,6 @@ async fn runs_native_query_with_collection_representation() -> anyhow::Result<()

#[tokio::test]
async fn runs_native_query_with_variable_sets() -> anyhow::Result<()> {
// Skip this test in MongoDB 5 because the example fails there. We're getting an error:
//
// > Kind: Command failed: Error code 5491300 (Location5491300): $documents' is not allowed in user requests, labels: {}
//
// This means that remote joins are not working in MongoDB 5
if let Ok(image) = std::env::var("MONGODB_IMAGE") {
if image == "mongo:5" {
return Ok(());
}
}

assert_yaml_snapshot!(
run_connector_query(
Connector::SampleMflix,
Expand Down
33 changes: 0 additions & 33 deletions crates/integration-tests/src/tests/remote_relationship.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,6 @@ use serde_json::json;

#[tokio::test]
async fn provides_source_and_target_for_remote_relationship() -> anyhow::Result<()> {
// Skip this test in MongoDB 5 because the example fails there. We're getting an error:
//
// > Kind: Command failed: Error code 5491300 (Location5491300): $documents' is not allowed in user requests, labels: {}
//
// This means that remote joins are not working in MongoDB 5
if let Ok(image) = std::env::var("MONGODB_IMAGE") {
if image == "mongo:5" {
return Ok(());
}
}

assert_yaml_snapshot!(
graphql_query(
r#"
Expand All @@ -40,17 +29,6 @@ async fn provides_source_and_target_for_remote_relationship() -> anyhow::Result<

#[tokio::test]
async fn handles_request_with_single_variable_set() -> anyhow::Result<()> {
// Skip this test in MongoDB 5 because the example fails there. We're getting an error:
//
// > Kind: Command failed: Error code 5491300 (Location5491300): $documents' is not allowed in user requests, labels: {}
//
// This means that remote joins are not working in MongoDB 5
if let Ok(image) = std::env::var("MONGODB_IMAGE") {
if image == "mongo:5" {
return Ok(());
}
}

assert_yaml_snapshot!(
run_connector_query(
Connector::SampleMflix,
Expand All @@ -70,17 +48,6 @@ async fn handles_request_with_single_variable_set() -> anyhow::Result<()> {

#[tokio::test]
async fn variable_used_in_multiple_type_contexts() -> anyhow::Result<()> {
// Skip this test in MongoDB 5 because the example fails there. We're getting an error:
//
// > Kind: Command failed: Error code 5491300 (Location5491300): $documents' is not allowed in user requests, labels: {}
//
// This means that remote joins are not working in MongoDB 5
if let Ok(image) = std::env::var("MONGODB_IMAGE") {
if image == "mongo:5" {
return Ok(());
}
}

assert_yaml_snapshot!(
run_connector_query(
Connector::SampleMflix,
Expand Down
11 changes: 0 additions & 11 deletions crates/integration-tests/src/tests/sorting.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,6 @@ use crate::graphql_query;

#[tokio::test]
async fn sorts_on_extended_json() -> anyhow::Result<()> {
// Skip this test in MongoDB 5 because the example fails there. We're getting an error:
//
// > Kind: Command failed: Error code 5491300 (Location5491300): $documents' is not allowed in user requests, labels: {}
//
// This doesn't affect native queries that don't use the $documents stage.
if let Ok(image) = std::env::var("MONGODB_IMAGE") {
if image == "mongo:5" {
return Ok(());
}
}

assert_yaml_snapshot!(
graphql_query(
r#"
Expand Down
2 changes: 1 addition & 1 deletion justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ test-e2e: (_arion "arion-compose/e2e-testing.nix" "test")

# Run `just test-integration` on several MongoDB versions
test-mongodb-versions:
MONGODB_IMAGE=mongo:5 just test-integration
MONGODB_IMAGE=mongo:6 just test-integration
MONGODB_IMAGE=mongo:7 just test-integration
MONGODB_IMAGE=mongo:8 just test-integration

# Runs a specified service in a specified project config using arion (a nix
# frontend for docker-compose). Propagates the exit status from that service.
Expand Down
Loading