这是indexloc提供的服务，不要输入任何密码
Skip to content

Add root config and update cli default #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 1, 2024
Merged

Add root config and update cli default #68

merged 12 commits into from
May 1, 2024

Conversation

codedmart
Copy link
Collaborator

@codedmart codedmart commented Apr 30, 2024 •
edited by jira bot
Loading

Describe your changes

Add an optional root configuration.json or configuration.yaml file to allow editing cli options. Update default sample size to 100.

MDB-133

@codedmart codedmart requested review from hallettj and dmoverton April 30, 2024 01:08
dmoverton
dmoverton reviewed Apr 30, 2024
View reviewed changes
dmoverton
dmoverton reviewed Apr 30, 2024
View reviewed changes
dmoverton
dmoverton reviewed Apr 30, 2024
View reviewed changes
dmoverton
dmoverton reviewed Apr 30, 2024
View reviewed changes
dmoverton
dmoverton reviewed Apr 30, 2024
View reviewed changes
@dmoverton
Copy link
Contributor

I think it would be useful if the update command wrote out a configuration.yaml file with the default options if it doesn't already exist. This would make it easier for the user to edit the options, rather than having to write the file from scratch. It also means users won't get an unexpected change in behaviour if the default options change in the future.

@codedmart
Copy link
Collaborator Author

I think it would be useful if the update command wrote out a configuration.yaml file with the default options if it doesn't already exist. This would make it easier for the user to edit the options, rather than having to write the file from scratch. It also means users won't get an unexpected change in behaviour if the default options change in the future.

Ah right I meant to do that and got side tracked. Thanks!

dmoverton
dmoverton reviewed Apr 30, 2024
View reviewed changes
dmoverton
dmoverton reviewed May 1, 2024
View reviewed changes
@codedmart codedmart force-pushed the codedmart/config branch from a731336 to ce08357 Compare May 1, 2024 13:18
hallettj
hallettj approved these changes May 1, 2024
View reviewed changes
@codedmart codedmart merged commit 845cc5a into main May 1, 2024
@codedmart codedmart deleted the codedmart/config branch May 1, 2024 17:10
@codedmart codedmart mentioned this pull request May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmoverton dmoverton dmoverton left review comments

@hallettj hallettj hallettj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codedmart @dmoverton @hallettj