这是indexloc提供的服务,不要输入任何密码
Skip to content

Mention MONGODB_DATABASE_URI environment variable in error message if it is missing #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

dmoverton
Copy link
Contributor

@dmoverton dmoverton commented Apr 23, 2024

Describe your changes

If the database URI is missing we want the error message to mention the environment variable MONGODB_DATABASE_URI instead of the command line option --connection-uri.
When run via the ddn CLI, the environment variable will be the primary means of specifying this option and it is confusing not to mention it.

Issue ticket number and link

MDB-119

Type

(Select only one. In case of multiple, choose the most appropriate)

  • highlight
  • enhancement
  • bugfix
  • behaviour-change
  • performance-enhancement
  • security-fix

@dmoverton dmoverton self-assigned this Apr 23, 2024
Copy link
Contributor

@daniel-chambers daniel-chambers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love how now the CLI args say --connection-uri is optional when it isn't. But I don't have a better solution since you can't customise the error message.

@dmoverton dmoverton merged commit 9066a73 into main Apr 23, 2024
@dmoverton dmoverton deleted the dmoverton/mdb-119/improve-cli-error-message branch April 23, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants