这是indexloc提供的服务,不要输入任何密码
Skip to content

Add collection name as an option for native queries #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 20, 2024

Conversation

codedmart
Copy link
Collaborator

Describe your changes

Add optional collection_name to native query configuration. When a collection_name is used in configuration the pipeline is run using that collection as the base.

Type

(Select only one. In case of multiple, choose the most appropriate)

  • highlight
  • enhancement
  • bugfix
  • behaviour-change
  • performance-enhancement
  • security-fix

Changelog entry

Add optional collection_name to native query configuration. When a collection_name is used in configuration the pipeline is run using that collection as the base.

@codedmart codedmart requested a review from hallettj April 19, 2024 22:19
Copy link
Collaborator

@hallettj hallettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make a corresponding change to the explain handler - it reads QueryTarget and applies basically the same logic that the query handler does.

As I said, I'd like to change the name to something other than "collection_name".

Otherwise it looks good!

@codedmart codedmart force-pushed the brandon/native-query-collection-name branch from bfd7a59 to f370944 Compare April 20, 2024 00:27
@codedmart codedmart merged commit 89ec531 into main Apr 20, 2024
@codedmart codedmart deleted the brandon/native-query-collection-name branch April 20, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants