ndc-test nix improvements and Chinook data fixes #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves some of the testing infrastructure, but stops short of actually integrating ndc-test in CI. We still need to make improvements to ndc-test and fix more bugs in the mongo connector before that will be possible.
Nix
The Nix arion testing configuration was modified slightly to support mounting the
snapshots
directory in the repo and reading and writing ndc-test snapshots to/from that directory. There are some example commands of how to do this commented out inproject-ndc-test.nix
. However, it's still configured to just do a basic "test" run because:Chinook data
The Chinook dataset had some significant issues, which have now been resolved! 😄 Namely:
JIRA: MDB-110