move v3-e2e-testing fetcher out of flake #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Removes the
v3-e2e-testinginput fromflake.nix, and moves it to a fetcher in the arion configuration that runs the e2e service. The e2e repo is private - if we keep it in the flake the entire nix setup will be broken for anyone who isn't set up to access the e2e repo with ssh authentication. Moving the fetcher to that specific arion config file prevents an authentication error unless you're specifically running e2e tests.The advantage of having inputs in
flake.nixis that we can update versions with commands likenix flake update, and nix handles locking versions automatically. OTOH withbuiltins.fetchGitwe have to edit the file to set the git revision that we want.