这是indexloc提供的服务,不要输入任何密码
Skip to content

check query request to determine whether response is foreach #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

hallettj
Copy link
Collaborator

@hallettj hallettj commented Apr 14, 2024

Describe your changes

We were getting errors in query responses with no matching rows because the response parsing interpreted the empty set of response rows as a foreach response. This change references the query request to determine whether or not to parse the response as a foreach.

MDB-19

@hallettj hallettj self-assigned this Apr 14, 2024
Copy link
Contributor

@dmoverton dmoverton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@hallettj hallettj merged commit 58b90ca into main Apr 15, 2024
@hallettj hallettj deleted the jesse/parse-empty-non-foreach-response branch April 15, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants