fix: otlp endpoint parsing for http protocol #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes OTLP endpoint parsing by distinguishing between gRPC and HTTP Protobuf protocol handling. The change ensures that HTTP Protobuf endpoints return the full endpoint URL instead of just the hostname:port, which is critical for preserving path components that HTTP OTLP endpoints often require.
Key Changes
- Separated the combined
OTLPProtocolGRPC, OTLPProtocolHTTPProtobufcase into distinct cases - gRPC protocol continues to return
host(hostname:port only) - HTTP Protobuf protocol now returns
endpoint(full URL with scheme and path)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the logic for parsing OTLP endpoints in the
provider.gofile. The main change ensures that the correct value is returned for different OTLP protocols, specifically distinguishing between gRPC and HTTP Protobuf.Protocol handling improvements:
func parseOTLPEndpoint, the return value for theOTLPProtocolHTTPProtobufcase is changed to returnendpointinstead ofhost, ensuring the correct endpoint is used for HTTP Protobuf connections.