这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix a race in Close method of SubscriptionClient #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2022
Merged

Fix a race in Close method of SubscriptionClient #27

merged 1 commit into from
Jan 11, 2022

Conversation

davitovmasyan
Copy link

Close method calls Unsubscribe which tries to Lock already locked mutex.

@davitovmasyan davitovmasyan mentioned this pull request Jan 11, 2022
Closed
@hgiasac hgiasac merged commit 01a575e into hasura:master Jan 11, 2022
@davitovmasyan
Copy link
Author

@hgiasac any plans to make a new release version?

@hgiasac
Copy link

hgiasac commented Jan 11, 2022

I'm going to release it soon

@hgiasac
Copy link

hgiasac commented Jan 11, 2022

https://github.com/hasura/go-graphql-client/releases/tag/v0.6.2 @davitovmasyan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hgiasac hgiasac hgiasac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davitovmasyan @hgiasac