这是indexloc提供的服务，不要输入任何密码
Skip to content

remove enable console from docker cmd and add it as env var (close #907) #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2018
Merged

remove enable console from docker cmd and add it as env var (close #907) #938

merged 1 commit into from
Nov 2, 2018

Conversation

@shahidhk
Copy link
Member

@shahidhk shahidhk commented Oct 30, 2018 •
edited
Loading

Description

Since HASURA_GRAPHQL_ENABLE_CONSOLE env var is introduced, --enable-console flag should be removed from the dockerfile cmd so that setting the env var to False can actually disable the console.

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@shahidhk shahidhk added the c/server Related to server label Oct 30, 2018
@shahidhk shahidhk requested review from 0x777 and ecthiender October 30, 2018 10:24
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 30, 2018

Review app available at: https://hge-ci-pull-938.herokuapp.com

ecthiender
ecthiender approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@ecthiender ecthiender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahidhk shahidhk merged commit f7da89e into hasura:master Nov 2, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Nov 2, 2018

Review app https://hge-ci-pull-938.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Aug 7, 2024
@dmoverton @hasura-bot
Avoid some unnecessary cloning (#938)
9f43576 
<!-- The PR description should answer 2 important questions: -->

### What

Avoid some unnecessary cloning during metadata resolve.

### How

Some data structures, such as `graphql_types` which are updated by
various stages of metadata resolve, were being unnecessarily cloned.
Instead of cloning from an immutable reference, we now move the value
into each stage and return it as part of the stage output.

V3_GIT_ORIGIN_REV_ID: 067698c3e004c70165fb0a8190542115a9f6cfb6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rakeshkky rakeshkky rakeshkky approved these changes

@0x777 0x777 Awaiting requested review from 0x777

+1 more reviewer

@ecthiender ecthiender ecthiender approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c/server Related to server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shahidhk @hasura-bot @ecthiender @rakeshkky