这是indexloc提供的服务，不要输入任何密码
Skip to content

update logo in console #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2018
Merged

update logo in console #934

merged 1 commit into from
Oct 31, 2018

Conversation

@surendran82
Copy link
Contributor

@surendran82 surendran82 commented Oct 30, 2018 •
edited
Loading

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@CLAassistant
Copy link

CLAassistant commented Oct 30, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@shark-h shark-h requested a review from praveenweb October 30, 2018 08:19
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 30, 2018

Review app available at: https://hge-ci-pull-934.herokuapp.com

praveenweb
praveenweb approved these changes Oct 31, 2018
View reviewed changes
Copy link
Member

@praveenweb praveenweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@praveenweb praveenweb added s/ok-to-merge Status: This pull request can be merged to master c/console Related to console labels Oct 31, 2018
@shahidhk shahidhk merged commit a32d94f into hasura:master Oct 31, 2018
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 31, 2018

Review app https://hge-ci-pull-934.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Aug 6, 2024
@0x777 @hasura-bot
Remove references to 'SmolStr's in QueryNode (#934)
6c9dad1 
Specifically, DataConnectorColumnName and DataConnectorName which are
wrappers on `SmolStr` and hence cheap to clone.

We want to use `Plan` as a physical node in the sql layer but given
datafusion's architecture, a physical node cannot contain references.
This is a small PR towards this effort.

V3_GIT_ORIGIN_REV_ID: 284dcfb4e8e7ce83705b415611c22e8a6e25e4be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveenweb praveenweb praveenweb approved these changes

Assignees

No one assigned

Labels

c/console Related to console s/ok-to-merge Status: This pull request can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@surendran82 @CLAassistant @hasura-bot @praveenweb @shahidhk