close #92 add waits for cli and server test #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahidhk
pushed a commit
to shahidhk/graphql-engine
that referenced
this pull request
Sep 11, 2018
hasura-bot
added a commit
that referenced
this pull request
Nov 24, 2020
…lose #5729) (#93) Co-authored-by: Dmitrii Grachikov <dgrachikov@gmail.com> Co-authored-by: Aleksandra Sikora <aleksandra@hasura.io> GITHUB_PR_NUMBER: 6032 GITHUB_PR_URL: #6032 Co-authored-by: Aleksandra Sikora <aleksandra@hasura.io> Co-authored-by: Dmitrii Grachikov <dgrachikov@gmail.com> GitOrigin-RevId: 44c2f5f
hgiasac
pushed a commit
to hgiasac/graphql-engine
that referenced
this pull request
Dec 19, 2023
* use `Name` instead of `String` for graphql schema fields * write custom `Deserialize` for `Name` * move validation to resolving stage * fix unintentional changes * add test fix lint * lint * address review comments Co-authored-by: Abhinav Gupta <abhinav@hasura.io> * make `Name` constructor private * make `Name::new` public to crate only * move test * remove `Name::new()` * cargo fmt * fix lint * address review comments Co-authored-by: Abhinav Gupta <abhinav@hasura.io> --------- Co-authored-by: Abhinav Gupta <abhinav@hasura.io> GitOrigin-RevId: 6608267fd6665d6f4320fbc5bc1b06f18a5606ce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.