validate the directory before executing migrate create (fix #585) #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Review app available at: https://hge-ci-pull-586.herokuapp.com |
arvi3411301
approved these changes
Oct 1, 2018
Contributor
|
Review app https://hge-ci-pull-586.herokuapp.com is deleted |
hasura-bot
pushed a commit
that referenced
this pull request
Feb 23, 2021
hasura-bot
pushed a commit
that referenced
this pull request
May 16, 2024
Bump Rust compiler to [1.78.0](https://blog.rust-lang.org/2024/05/02/Rust-1.78.0.html). Fix a few new warnings. Functional no-op. V3_GIT_ORIGIN_REV_ID: 3d8f0626ebb988fb7bd80ad8aa5d6c2d8c3d7f24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The recent bugfix to accept
--projectflag had resulted in some refactoring and the validate function is not being called frommigrate createcommand anymore. Tests did not capture this as the tests are run after the initialisation step. Need to refactor tests to mimic the exact execution.What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
No
Related Issue
#585
Solution and Design
The validate function has been explicitly added to create command. Earlier it was part of the parent command, but that had been refactored recently.
Type
Checklist: