console: automatically wrap default column values in quotes (close #418) #5805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy preview for hasura-docs ready! 🔨 Explore the source changes: d63be6f 🔍 Inspect the deploy logs: https://app.netlify.com/sites/hasura-docs/deploys/5fca506e04b45c0007e68367 😎 Browse the preview: https://deploy-preview-5805--hasura-docs.netlify.app |
kolharsam
reviewed
Sep 22, 2020
Contributor
kolharsam
left a comment
There was a problem hiding this comment.
Minor changes suggested. Otherwise, it looks good! 👍
console/src/components/Services/Data/TableModify/ModifyActions.js
Outdated
Show resolved
Hide resolved
beerose
suggested changes
Oct 14, 2020
added 2 commits
December 4, 2020 16:04
hasura-bot
added a commit
that referenced
this pull request
Dec 8, 2020
…) (#162) Co-authored-by: Varun Choudhary <varun@hasura.io> Co-authored-by: Sameer Kolhar <sameer@hasura.io> Co-authored-by: Aleksandra Sikora <aleksandra@hasura.io> GITHUB_PR_NUMBER: 5805 GITHUB_PR_URL: #5805 Co-authored-by: Varun Choudhary <varun@hasura.io> Co-authored-by: Sameer Kolhar <sameer@hasura.io> Co-authored-by: Aleksandra Sikora <aleksandra@hasura.io> GitOrigin-RevId: 8c80998
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #418
Description
This PR automatically wraps the default value of json type column in quotes
' '. So that it will throw no error.Affected components