这是indexloc提供的服务，不要输入任何密码
Skip to content

console: make error notifications dismissible only after clicking on the close button (close #5533) #5780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 28, 2020
Merged

console: make error notifications dismissible only after clicking on the close button (close #5533) #5780

merged 9 commits into from
Sep 28, 2020

Conversation

@Varun-Choudhary
Copy link
Contributor

@Varun-Choudhary Varun-Choudhary commented Sep 14, 2020

Closes: #5533

Description

Changed the Dismissible property of React-Notifiction-System so that the error notification will disable by clicking on X button only.

Affected components

  • Console

@Varun-Choudhary Varun-Choudhary requested a review from a team as a code owner September 14, 2020 08:09
@netlify
Copy link

netlify bot commented Sep 14, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit b5948b6

https://deploy-preview-5780--hasura-docs.netlify.app

@kolharsam kolharsam changed the title Console: Error Notification are disabled by clicking on dismissible button only console: Error Notification are disabled by clicking on dismissible button Sep 14, 2020
beerose
beerose reviewed Sep 14, 2020
View reviewed changes
beerose
beerose approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@beerose beerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Console

@beerose beerose changed the title console: Error Notification are disabled by clicking on dismissible button console: make error notifications dismissible after clicking on the close button (close #5533) Sep 14, 2020
@beerose beerose changed the title console: make error notifications dismissible after clicking on the close button (close #5533) console: make error notifications dismissible only after clicking on the close button (close #5533) Sep 15, 2020
tirumaraiselvan
tirumaraiselvan approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cl

beerose
beerose reviewed Sep 28, 2020
View reviewed changes
@kodiakhq kodiakhq bot merged commit daeb120 into hasura:master Sep 28, 2020
beerose pushed a commit to beerose/graphql-engine that referenced this pull request Nov 10, 2020
@Varun-Choudhary
console: make error notifications dismissible only after clicking on …
81b49da 
…the close button (close hasura#5533) (hasura#5780)

hasura#5780
@beerose beerose mentioned this pull request Nov 10, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

+1 more reviewer

@beerose beerose beerose approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@beerose beerose

Labels

c/console Related to console no-changelog-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Simple Click on error panel in console close it

3 participants

@Varun-Choudhary @tirumaraiselvan @beerose