server: accept only non-negative integers for batch size and refetch interval (close #5653) #5759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit 43cb034 |
kolharsam
commented
Sep 9, 2020
| - server: add action-like URL templating for event triggers and remote schemas (fixes #2483) | ||
| - server: change `created_at` column type from `timestamp` to `timestamptz` for scheduled triggers tables (fix #5722) | ||
| - server: allow configuring timeouts for actions (fixes #4966) | ||
| - server: accept only non-negative integers for batch size and refetch interval (close #5653) (#5759) |
Contributor
There was a problem hiding this comment.
I don't think we needed a changelog as it was rather non-user facing or atleast obviously expected.
tirumaraiselvan
approved these changes
Sep 17, 2020
Contributor
tirumaraiselvan
left a comment
There was a problem hiding this comment.
There is an optional changelog comment. but not important.
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5653
Description
This PR fixes the bug that allowed users to pass negative values for batch size and the refetch interval. This PR also adds a spec file for the
NonNegativeInttype that is introduced in this PR.Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR. If no changelog is required, then add theno-changelog-requiredlabel.Affected components
Server checklist
Catalog upgrade
Does this PR change Hasura Catalog version?
Metadata
Does this PR add a new Metadata feature?
GraphQL
Breaking changes