console: trim role names when submitting the form (close #5553) #5748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kolharsam
reviewed
Sep 9, 2020
91f4c8b to
f03c637
Compare
beerose
suggested changes
Sep 10, 2020
console/src/components/Services/Data/TablePermissions/Actions.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Aleksandra Sikora <aleksandra@hasura.io>
tirumaraiselvan
approved these changes
Sep 15, 2020
Contributor
tirumaraiselvan
left a comment
There was a problem hiding this comment.
A changelog might have been good since it's a user reported issue so it's definitely user-facing ;)
But, it's also very trivial so it's okay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier, when creating a role in permissions, we could not give whitespaces, as whitespaces were getting trimmed. This pull request fixes that issue.
Description
fix #5553
Changelog (TODO)
CHANGELOG.mdis updated with user-facing content relevant to this PR. If no changelog is required, then add theno-changelog-requiredlabel.Affected components
Related Issues
Solution and Design
Steps to test and verify
Go to data section, select a table and select permissions, create a role with trailing whitespaces. For example
admin role.Limitations, known bugs & workarounds