这是indexloc提供的服务，不要输入任何密码
Skip to content

console: select first operator by default (close #5729) #5730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

console: select first operator by default (close #5729) #5730

wants to merge 8 commits into from

Conversation

@bertyhell
Copy link
Contributor

@bertyhell bertyhell commented Sep 5, 2020 •
edited by rikinsk
Loading

Description

When filtering rows in the data tab in the hasura console, the first operator will be selected by default.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

not yet, I'm not sure under which version I need to add this.

Affected components

  • Console

Related Issues

#5729

Solution and Design

image

Steps to test and verify

  • login to the console
  • go to the data tab
  • select a table
  • see the the first filter has the first operator selected by default. This will probably be _eq in most setups.

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:

Breaking changes

  • No Breaking changes
  • There are breaking changes:

@bertyhell bertyhell requested a review from a team as a code owner September 5, 2020 14:09
@hasura-bot
Copy link
Contributor

hasura-bot commented Sep 5, 2020

Beep boop! 🤖

Hey @bertyhell, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@beerose beerose self-assigned this Sep 5, 2020
@bertyhell bertyhell requested a review from a team as a code owner September 5, 2020 14:48
@beerose beerose assigned rikinsk and unassigned beerose Oct 1, 2020
rikinsk
rikinsk requested changes Oct 13, 2020
View reviewed changes
Copy link
Member

@rikinsk rikinsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bertyhell. Thanks a ton for raising this PR. We really appreciate it.

Unfortunately the solution implemented here does not work as expected. The operator dropdown is a controlled element and the selected value comes from the redux state. hence just displaying the first element as selected will not actually set the operator in the state and when the Run Query button is hit the filter will not actually be applied. The actual solution might involve setting the appropriate state and shouldnt need any changes to the UI components.

@rikinsk rikinsk removed their assignment Oct 13, 2020
@bertyhell bertyhell mentioned this pull request Oct 17, 2020
Closed
@beerose
Copy link
Contributor

beerose commented Oct 19, 2020

Closing in favour of #6032, as discussed in #5729.

@beerose beerose closed this Oct 19, 2020
@hasura-bot
Copy link
Contributor

hasura-bot commented Oct 19, 2020

Beep boop! 🤖

Hey @bertyhell!

Sorry that your PR wasn’t merged.

Do take a look at any of the other open issues to see if you’d like to take something up! We’re around on Discord if you have any questions 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikinsk rikinsk rikinsk requested changes

Assignees

No one assigned

Labels

c/console Related to console community-contrib 🙏🏽

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bertyhell @hasura-bot @beerose @rikinsk