这是indexloc提供的服务，不要输入任何密码
Skip to content

Server: add URL templating for event triggers and remote schemas #5760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 10, 2020
Merged

Server: add URL templating for event triggers and remote schemas #5760

merged 9 commits into from
Sep 10, 2020

Conversation

@codingkarthik
Copy link
Contributor

@codingkarthik codingkarthik commented Sep 9, 2020 •
edited
Loading

Add action-like URL templating for event triggers and remote schemas

fixes #2483

Description

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code

    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields

    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

@codingkarthik codingkarthik requested a review from a team as a code owner September 9, 2020 12:40
@netlify
Copy link

netlify bot commented Sep 9, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 65f66e1

https://deploy-preview-5760--hasura-docs.netlify.app

jberryman
jberryman approved these changes Sep 9, 2020
View reviewed changes
Copy link
Collaborator

@jberryman jberryman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a couple suggestions you can take at your discretion

server/src-lib/Hasura/RQL/Types/Common.hs Outdated
Comment on lines 311 to 313
case urlTemplate of
Left e -> Left $ "Parsing URL template failed: " <> T.pack e
Right v -> Right $ InputWebhook v
Copy link
Collaborator

@jberryman jberryman Sep 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
case urlTemplate of
Left e -> Left $ "Parsing URL template failed: " <> T.pack e
Right v -> Right $ InputWebhook v
bimap (\e-> "Parsing URL template failed: " <> T.pack e) InputWebhook urlTemplate

only if you want. You'll need to import Data.Bifunctor probably.

codingkarthik and others added 2 commits September 10, 2020 11:01
@codingkarthik @jberryman
Update scripts/dev.sh
696e315 
Co-authored-by: Brandon Simmons <brandon.m.simmons@gmail.com>
@codingkarthik
apply bimap suggestion
65f66e1
tirumaraiselvan
tirumaraiselvan approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog

@codingkarthik codingkarthik merged commit 92ef504 into hasura:master Sep 10, 2020
stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@codingkarthik @jberryman @stevefan1999-personal
Server: add URL templating for event triggers and remote schemas (has…
0941c43 
…ura#5760)

* add url templating for event triggers

Co-authored-by: Brandon Simmons <brandon.m.simmons@gmail.com>
@tirumaraiselvan tirumaraiselvan added this to the v1.3.3 milestone Nov 3, 2020
codingkarthik added a commit to codingkarthik/graphql-engine that referenced this pull request Nov 6, 2020
@codingkarthik @jberryman
Server: add URL templating for event triggers and remote schemas (has…
c187d0b 
…ura#5760)

* add url templating for event triggers

Co-authored-by: Brandon Simmons <brandon.m.simmons@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jberryman jberryman jberryman approved these changes

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.3.3

Development

Successfully merging this pull request may close these issues.

add action-style templating of webhook URL for event trigger and remote schemas

3 participants

@codingkarthik @jberryman @tirumaraiselvan